Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource_group: don't accumulate tokens when burstlimit less than 0 (#7626) #7658

Merged
merged 2 commits into from
Jan 4, 2024
Merged

resource_group: don't accumulate tokens when burstlimit less than 0 (#7626) #7658

merged 2 commits into from
Jan 4, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7626

What problem does this PR solve?

Issue Number: ref #7206

What is changed and how does it work?

We can find a large number from default resource group.

{"r_u":{"settings":{"fill_rate":2147483647,"burst_limit":-1},"state":{"tokens":29860685960413220,"last_update":"2023-12-27T08:19:16.269363735Z","initialized":true}}}

So don't accumulate tokens when burstlimit less than 0

Check List

Tests

  • Unit test

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@CabinfeverB @ti-chi-bot
don't accumulate tokens
9fb24c8 
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 3, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 3, 2024
Merged
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. label Jan 3, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 3, 2024 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 3, 2024
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and Yisaer January 3, 2024 10:12
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 3, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 4, 2024
This was referenced Jan 4, 2024
Merged
Merged
@codecov Codecov
Copy link

codecov bot commented Jan 4, 2024 •
edited
Loading

Codecov Report

Merging #7658 (9fb24c8) into release-7.5 (c9c9979) will decrease coverage by 0.09%.
Report is 3 commits behind head on release-7.5.
The diff coverage is 93.97%.

❗ Current head 9fb24c8 differs from pull request most recent head af6adbd. Consider uploading reports for the commit af6adbd to get more accurate results

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-7.5    #7658      +/-   ##
===============================================
- Coverage        74.74%   74.66%   -0.09%     
===============================================
  Files              443      443              
  Lines            47891    47923      +32     
===============================================
- Hits             35795    35780      -15     
- Misses            8950     8982      +32     
- Partials          3146     3161      +15
Flag Coverage Δ
unittests 74.66% <93.97%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@CabinfeverB
Copy link
Member

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 4, 2024

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 4, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 9fb24c8

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit a276843 into tikv:release-7.5 Jan 4, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@nolouch nolouch nolouch approved these changes

@JmPotato JmPotato Awaiting requested review from JmPotato

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees

@CabinfeverB CabinfeverB

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @CabinfeverB @nolouch